Re: com php-src: Fix #65550: get_browser() incorrectlyparsers entries with "+" sign: NEWS ext/standard/browscap.c
ext/standard/tests/misc/bug65550.phpt

On 27.08.2016 at 02:56, Kalle Sommer Nielsen wrote: > 2016-08-27 1:12 GMT+02:00 Christoph Michael Becker <cmb@php.net>: >> Fix #65550: get_browser() incorrectly parsers entries with "+" sign > > I was wondering about get_browser() and its potential userbase, and if > it was time to maybe deprecate this, as backend user agent sniffing, > is hopefully considered bad practice, and most of its functionality > can be implemented in userland fairly easily. Any inputs on this? Actually, there is browscap-php[1] which is the only officially supported library[2] for the browscap inis. Furthermore there are performance issues[3]. Quoting from bug #70490: | the performance are really bad even with last versions, so I used | php_browscap (https://github.com/browscap/browscap-php). Apparently, PHP is faster than C! ;-) Kidding aside, unless somebody is willing to improve the implementation of get_browser(), it might indeed be best to deprecate this function. Still, it would be good to solve the performance regression anyway. [1] <https://github.com/browscap/browscap-php/> [2] <https://browscap.org/> [3] <https://bugs.php.net/bug.php?id=70490> <http://php.net/manual/en/function.get-browser.php#118632> -- Christoph M. Becker