Re: com php-src: Make tests a little more resilient: ext/gd/tests/bug22544.phpt ext/gd/tests/bug43828.phpt ext/gd/tests/bug72604.phpt
ext/gd/tests/imagearc_basic.phpt ext/gd/tests/imagearc_error1.phpt ext/gd/tests/imagearc_variation1.phpt ext/gd
| From: | Christoph M. Becker | Date: | Tue, 30 Aug 2016 17:20:09 +0000 |
| Subject: | Re: com php-src: Make tests a little more resilient: ext/gd/tests/bug22544.phpt ext/gd/tests/bug43828.phpt ext/gd/tests/bug72604.phpt ext/gd/tests/imagearc_basic.phpt ext/gd/tests/imagearc_error1.phpt ext/gd/tests/imagearc_variation1.phpt ext/gd |
||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-94173@lists.php.net to get a copy of this message | ||
Hi Anatol!
On 30.08.2016 at 18:33, Anatol Belski wrote:
>
>> -----Original Message-----
>> From: Christoph Michael Becker [mailto:cmb@php.net]
>> Sent: Wednesday, August 17, 2016 6:00 PM
>> To: php-cvs@lists.php.net
>> Subject: [PHP-CVS] com php-src: Make tests a little more resilient:
>> ext/gd/tests/bug22544.phpt ext/gd/tests/bug43828.phpt
>> ext/gd/tests/bug72604.phpt ext/gd/tests/imagearc_basic.phpt
>> ext/gd/tests/imagearc_error1.phpt ext/gd/tests/imagearc_variation1.phpt
>> ext/gd/tes
>>
>> Commit: a3159d29bb24d5c946c14b7aa33e96bebcd56e59
>> Author: Christoph M. Becker <cmbecker69@gmx.de> Wed, 17 Aug 2016
>> 17:59:33 +0200
>> Parents: 48198e4c257825ab89ee027bff5a93fc2cd59601
>> Branches: PHP-5.6 PHP-7.0 PHP-7.1 master
>>
>> Link: http://git.php.net/?p=php-
>> src.git;a=commitdiff;h=a3159d29bb24d5c946c14b7aa33e96bebcd56e59
>>
>> Log:
>> Make tests a little more resilient
>>
>> PNG allows identical images to be stored differently what makes nearly all tests
>> checking the MD5 hash of the PNG representation fail with external libgd. For
>> now, we use the GD format instead, which doesn't allow for such differences.
>>
>> Of course, this md5() checking should be replaced by a image diffing feature in
>> the long run.
>
> I've got these fails at least in 7.0 x64
>
> TEST 1/3 [C:\php-sdk\php70\vc14\x64\php-src\ext\gd\tests\imagecolorallocatealpha_basic.phpt]
> ========DIFF========
> 001+ string(32) "d776984f1a2ce89be189bd16db303427"
> 001- string(32) "0981ef94ee2209a8dccb59aa8ad07e18"
> ========DONE========
> FAIL Testing imagecolorallocatealpha()
> [C:\php-sdk\php70\vc14\x64\php-src\ext\gd\tests\imagecolorallocatealpha_basic.phpt]
> TEST 2/3 [C:\php-sdk\php70\vc14\x64\php-src\ext\gd\tests\imageconvolution_basic.phpt]
> ========DIFF========
> 001+ 0b35b0ded5e20eff78f4cd7850579dab
> 001- 20979b45f8772cdbd78262af4e332638
> ========DONE========
> FAIL Testing imageconvolution() of GD library
> [C:\php-sdk\php70\vc14\x64\php-src\ext\gd\tests\imageconvolution_basic.phpt]
> TEST 3/3 [C:\php-sdk\php70\vc14\x64\php-src\ext\gd\tests\libgd00100.phpt]
> ========DIFF========
> 001+ 155d2437ff8000e68ae703ff198ad926
> 001- df7253c765280396f303166f10ba9283
> ========DONE========
>
> Seems to be related to the test changes in this or the decsendant commits. Could you please
> check?
Indeed, on Windows the tests are failing. A quick check indicates that
imagegd() doesn't behave identical. I'll investigate right away.
--
Christoph M. Becker