Re: com php-src: Fixed Bug #66964 mb_convert_variables() cannot detect recursion: ext/mbstring/mbstring.c ext/mbstring/tests/bug66964.phpt
| From: | Yasuo Ohgaki | Date: | Wed, 07 Sep 2016 03:00:29 +0000 |
| Subject: | Re: com php-src: Fixed Bug #66964 mb_convert_variables() cannot detect recursion: ext/mbstring/mbstring.c ext/mbstring/tests/bug66964.phpt | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-94354@lists.php.net to get a copy of this message | ||
Hi Christoph,
On Tue, Sep 6, 2016 at 8:51 PM, Christoph M. Becker <cmbecker69@gmx.de> wrote:
> On 06.09.2016 at 09:05, Yasuo Ohgaki wrote:
>
>> Commit: a25f6f89cd68b5e3ba73381094771a011aec6f04
>> Author: Yasuo Ohgaki <yohgaki@php.net> Tue, 6 Sep 2016 16:05:34 +0900
>> Parents: 8aad3131a1d00e191db1b3b27aed6e7fae269f13
>> Branches: PHP-5.6 PHP-7.0 PHP-7.1 master
>>
>> Link:
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=a25f6f89cd68b5e3ba73381094771a011aec6f04
>>
>> Log:
>> Fixed Bug #66964 mb_convert_variables() cannot detect recursion
>
> It appears that after this commit ext/mbstring/tests/bug26639.phpt
> always fails on PHP-5.6 only, see e.g.
> <https://travis-ci.org/php/php-src/jobs/157845693>.
> Possibly only the
> test case needs to be fixed.
>
> Can you please have a look at this issue?
You are right about test.
I removed unneeded zval separation. This is the reason why
ref count changed. I'll fix it!
Thank you!
--
Yasuo Ohgaki
yohgaki@ohgaki.net