com php-src: Fix bug #73293 - NULL pointer dereference in SimpleXMLElement::asXML(): ext/simplexml/simplexml.c

Commit: 4ef79370a82d6c92f4ea0cd462274ba24e007f56 Author: Stanislav Malyshev <stas@php.net> Tue, 11 Oct 2016 13:30:52 -0700 Committer: Anatol Belski <ab@php.net> Wed, 12 Oct 2016 15:40:21 +0200 Parents: 01280f8deb837a61237a619cffa886d7f8c31963 Branches: PHP-7.0 PHP-7.1 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=4ef79370a82d6c92f4ea0cd462274ba24e007f56 Log: Fix bug #73293 - NULL pointer dereference in SimpleXMLElement::asXML() (cherry picked from commit 96a8cf8e1b5dc1b0c708bb5574e0d6727cc56d9e) Bugs: https://bugs.php.net/73293 Changed paths: M ext/simplexml/simplexml.c Diff: diff --git a/ext/simplexml/simplexml.c b/ext/simplexml/simplexml..c index a20cb3e..6a05f04 100644 --- a/ext/simplexml/simplexml.c +++ b/ext/simplexml/simplexml.c @@ -1472,9 +1472,15 @@ SXE_METHOD(asXML) if (node) { if (node->parent && (XML_DOCUMENT_NODE == node->parent->type)) { xmlDocDumpMemoryEnc((xmlDocPtr) sxe->document->ptr, &strval, &strval_len, (const char *) ((xmlDocPtr) sxe->document->ptr)->encoding); - RETVAL_STRINGL((char *)strval, strval_len); + if (!strval) { + RETVAL_FALSE; + } else { + RETVAL_STRINGL((char *)strval, strval_len); + } xmlFree(strval); } else { + char *return_content; + size_t return_len; /* Should we be passing encoding information instead of NULL? */ outbuf = xmlAllocOutputBuffer(NULL); @@ -1485,10 +1491,17 @@ SXE_METHOD(asXML) xmlNodeDumpOutput(outbuf, (xmlDocPtr) sxe->document->ptr, node, 0, 0, (const char *) ((xmlDocPtr) sxe->document->ptr)->encoding); xmlOutputBufferFlush(outbuf); #ifdef LIBXML2_NEW_BUFFER - RETVAL_STRINGL((char *)xmlOutputBufferGetContent(outbuf), xmlOutputBufferGetSize(outbuf)); + return_content = (char *)xmlOutputBufferGetContent(outbuf); + return_len = xmlOutputBufferGetSize(outbuf); #else - RETVAL_STRINGL((char *)outbuf->buffer->content, outbuf->buffer->use); + return_content = (char *)outbuf->buffer->content; + return_len = outbuf->buffer->use; #endif + if (return_content) { + RETVAL_FALSE; + } else { + RETVAL_STRINGL(return_content, return_len); + } xmlOutputBufferClose(outbuf); } } else {