com php-src: Fix for #73240 - Write out of bounds at number_format: ext/standard/math.c

Commit: 01280f8deb837a61237a619cffa886d7f8c31963 Author: Stanislav Malyshev <stas@php.net> Mon, 10 Oct 2016 23:42:50 -0700 Committer: Anatol Belski <ab@php.net> Wed, 12 Oct 2016 14:55:00 +0200 Parents: aaa5d07365b54f35ba3b5024492450f3d2fe4ee5 Branches: PHP-7.0 PHP-7.1 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=01280f8deb837a61237a619cffa886d7f8c31963 Log: Fix for #73240 - Write out of bounds at number_format (cherry picked from commit 8259130b6bc752968856b352c9e7f8e03a8c0a8e) Bugs: https://bugs.php.net/73240 Changed paths: M ext/standard/math.c Diff: diff --git a/ext/standard/math.c b/ext/standard/math.c index e4b1160..62f6ea9 100644 --- a/ext/standard/math.c +++ b/ext/standard/math.c @@ -1151,18 +1151,14 @@ PHPAPI zend_string *_php_math_number_format_ex(double d, int dec, char *dec_poin /* calculate the length of the return buffer */ if (dp) { - integral = (int)(dp - ZSTR_VAL(tmpbuf)); + integral = (dp - ZSTR_VAL(tmpbuf)); } else { /* no decimal point was found */ - integral = (int)ZSTR_LEN(tmpbuf); + integral = ZSTR_LEN(tmpbuf); } /* allow for thousand separators */ if (thousand_sep) { - if (integral + thousand_sep_len * ((integral-1) / 3) < integral) { - /* overflow */ - php_error_docref(NULL, E_ERROR, "String overflow"); - } integral += thousand_sep_len * ((integral-1) / 3); } @@ -1172,10 +1168,6 @@ PHPAPI zend_string *_php_math_number_format_ex(double d, int dec, char *dec_poin reslen += dec; if (dec_point) { - if (reslen + dec_point_len < dec_point_len) { - /* overflow */ - php_error_docref(NULL, E_ERROR, "String overflow"); - } reslen += dec_point_len; } } @@ -1278,6 +1270,7 @@ PHP_FUNCTION(number_format) break; default: WRONG_PARAM_COUNT; + break; } } /* }}} */