com php-src: Fix pthreads detection when cross-compiling: TSRM/threads.m4

Commit: e6bbc00964d86b4b8ecb6a8e26bf9e3af47a4b98 Author: Fabrice Fontaine <fabrice.fontaine@orange.com> Tue, 11 Oct 2016 15:16:26 +0200 Parents: ca6e35f7a52a60bab22c6a802ee7e4b09eabb8a5 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=e6bbc00964d86b4b8ecb6a8e26bf9e3af47a4b98 Log: Fix pthreads detection when cross-compiling pthreads are not working when cross-compiling, indeed configure sets pthreads_working to no if cross_compiling is detected. This behavior is implemented in PTHREADS_CHECK. This function call AC_CACHE_CHECK twice to retrieve ac_cv_pthreads_cflags and ac_cv_pthreads_lib. In these calls, the function PTHREADS_CHECK_COMPILE will call AC_TRY_RUN function which will update the global pthreads_working variable. This is not compliant with autoconf AC_CACHE_CHECK rules which specify that "The commands-to-set-it must have no side effects except for setting the variable cache-id". So, this patch replaces pthread_working assignments with assignments on a new local pthread_checked variable. Value of ptreads_working is computed outside AC_CACHE_CHECK function depending on value of ac_cv_pthreads_cflags and ac_cv_pthreads_lib. Moreover, AC_TRY_RUN call is replaced by AC_TRY_LINK which will work when cross-compiling. Without this modification, thread safety option (--enable-maintainer-zts) can not be enabled on embedded buildsystems such as buildroot. Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com> Changed paths: M TSRM/threads.m4 Diff: diff --git a/TSRM/threads.m4 b/TSRM/threads.m4 index 38494ce..7ef9202 100644 --- a/TSRM/threads.m4 +++ b/TSRM/threads.m4 @@ -66,9 +66,10 @@ dnl dnl Check whether the current setup can use POSIX threads calls dnl AC_DEFUN([PTHREADS_CHECK_COMPILE], [ -AC_TRY_RUN( [ +AC_TRY_LINK( [ #include <pthread.h> #include <stddef.h> + ], [ void *thread_routine(void *data) { return data; @@ -81,17 +82,10 @@ int main() { pthread_mutexattr_init(&mattr); return pthread_create(&thd, NULL, thread_routine, &data); } ], [ - pthreads_working=yes - ], [ - pthreads_working=no + pthreads_checked=yes ], [ - dnl For cross compiling running this test is of no use. NetWare supports pthreads - pthreads_working=no - case $host_alias in - *netware*) - pthreads_working=yes - esac -] + pthreads_checked=no + ] ) ] )dnl dnl dnl PTHREADS_CHECK() @@ -129,30 +123,34 @@ else CFLAGS="$CFLAGS $flag" PTHREADS_CHECK_COMPILE CFLAGS=$ac_save - if test "$pthreads_working" = "yes"; then + if test "$pthreads_checked" = "yes"; then ac_cv_pthreads_cflags=$flag break fi done fi -fi -]) + ]) -AC_CACHE_CHECK(for pthreads_lib, ac_cv_pthreads_lib,[ -ac_cv_pthreads_lib= -if test "$pthreads_working" != "yes"; then - for lib in pthread pthreads c_r; do - ac_save=$LIBS - LIBS="$LIBS -l$lib" - PTHREADS_CHECK_COMPILE - LIBS=$ac_save - if test "$pthreads_working" = "yes"; then - ac_cv_pthreads_lib=$lib - break - fi - done + AC_CACHE_CHECK(for pthreads_lib, ac_cv_pthreads_lib,[ + ac_cv_pthreads_lib= + if test "$pthreads_working" != "yes"; then + for lib in pthread pthreads c_r; do + ac_save=$LIBS + LIBS="$LIBS -l$lib" + PTHREADS_CHECK_COMPILE + LIBS=$ac_save + if test "$pthreads_checked" = "yes"; then + ac_cv_pthreads_lib=$lib + break + fi + done + fi + ]) + + if test "x$ac_cv_pthreads_cflags" != "x" -o "x$ac_cv_pthreads_lib" != "x"; then + pthreads_working="yes" + fi fi -]) if test "$pthreads_working" = "yes"; then threads_result="POSIX-Threads found"