Re: Re: com php-src: Merge branch 'pull-request/1808': ext/standard/tests/network/dns_get_mx.phpt
| From: | Joe Watkins | Date: | Tue, 18 Oct 2016 09:34:21 +0000 |
| Subject: | Re: Re: com php-src: Merge branch 'pull-request/1808': ext/standard/tests/network/dns_get_mx.phpt | ||
| References: | 1 2 3 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-95186@lists.php.net to get a copy of this message | ||
Morning all,
Yes, we most probably should test against our own domains.
Christopher would you like to update those tests, or want me to do it ?
Cheers
Joe
On Tue, Oct 18, 2016 at 12:19 AM, Stanislav Malyshev <smalyshev@gmail.com>
wrote:
> Hi!
>
> >> +--FILE--
> >> +<?php
> >> +$domains = array('yahoo.co.jp', 'yahoo.com',
> >> 'es.yahoo.com', '
> fr.yahoo.com', 'it.yahoo.com');
> >
> > Shouldn't we test against domains that are under our control?
>
> I agree, depending on domains that may very well be removed without our
> knowledge is probably not the best. Can't we just use php.net ones?
>
> --
> Stas Malyshev
> smalyshev@gmail.com
>