RE: [PHP-CVS] com php-src: add some float limits constants: main/main.c
| From: | Anatol Belski | Date: | Wed, 26 Oct 2016 23:50:16 +0000 |
| Subject: | RE: [PHP-CVS] com php-src: add some float limits constants: main/main.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-95298@lists.php.net to get a copy of this message | ||
Hi Kalle,
> -----Original Message-----
> From: kalle.php@gmail.com [mailto:kalle.php@gmail.com] On Behalf Of Kalle
> Sommer Nielsen
> Sent: Thursday, October 27, 2016 12:20 AM
> To: Anatol Belski <ab@php.net>
> Cc: php-cvs@lists.php.net
> Subject: Re: [PHP-CVS] com php-src: add some float limits constants:
> main/main.c
>
> Hi Anatol
>
> 2016-10-26 18:10 GMT+02:00 Anatol Belski <ab@php.net>:
> > + REGISTER_MAIN_DOUBLE_CONSTANT("PHP_FLOAT_EPSILON",
> DBL_EPSILON, CONST_PERSISTENT | CONST_CS);
> > + REGISTER_MAIN_DOUBLE_CONSTANT("PHP_FLOAT_MAX", DBL_MAX,
> CONST_PERSISTENT | CONST_CS);
> > + REGISTER_MAIN_DOUBLE_CONSTANT("PHP_FLOAT_MIN", DBL_MIN,
> > + CONST_PERSISTENT | CONST_CS);
>
> Remember to document this in UPGRADING and NEWS, unless you intend to
> merge it :)
>
Yeah, that's what we usually do.
Regards
Anatol