RE: [PHP-CVS] com php-src: Add VT100 support for Windows: ext/standard/basic_functions.c ext/standard/streamsfuncs.c ext/standard/streamsfuncs.h
run-tests.php sapi/cli/php_cli.c tests/output/sapi_windows_vt100_support.inc tests/output/sapi_windows_vt100_s

Hi Matteo, > -----Original Message----- > From: Matteo Beccati [mailto:php@beccati.com] > Sent: Monday, October 31, 2016 9:43 AM > To: php-cvs@lists.php.net > Cc: Anatol Belski <ab@php.net>; Michele Locati <michele@locati.it> > Subject: Re: [PHP-CVS] com php-src: Add VT100 support for Windows: > ext/standard/basic_functions.c ext/standard/streamsfuncs.c > ext/standard/streamsfuncs.h run-tests.php sapi/cli/php_cli.c > tests/output/sapi_windows_vt100_support.inc > tests/output/sapi_windows_vt100_s > > Hi Anatol, Michele, > > since this commit, I've started to see failures on my CI: > > https://revive.beccati.com/bamboo/browse/PHP-SRC-984 > > in the stream_isatty*.phpt test. Would you mind having a look? > Thanks for checking. I've just retried on several other boxes, but unfortunately none reproduces the fails :( . I looked also to get the exact command line the tests are run with, could find it on the related CI page. For what I could see, the issue might be related to the changes in run-tests.php. Earlier, STDERR was always redirected into STDOUT, whereby in the patch there are new sections that change this behavior in the relevant tests. Were it about this guess, it'd be useful to check the exact command line as the CI tool might do yet other redirections that would affect those tests. It could be also something different on a particular system, but hard to guess. Matteo, seems I've no choice than asking you to do some check in this regard directly on the CI box, as it's hard to move forward without a reproducer. Or maybe Michele has a better idea, while looking at the fails. Thanks Anatol > > On 28/10/2016 19:23, Anatol Belski wrote: > > Commit: 33301d5bae4964f74fd1fc8c4fc485abfde0378e > > Author: Michele Locati <michele@locati.it> Mon, 29 Aug 2016 11:57:53 > +0200 > > Committer: Anatol Belski <ab@php.net> Fri, 28 Oct 2016 19:23:00 +0200 > > Parents: 946eb9b452302a258c90752a9a4c81d1824c1a3a > > Branches: master > > > > Link: http://git.php.net/?p=php- > src.git;a=commitdiff;h=33301d5bae4964f74fd1fc8c4fc485abfde0378e > > > -- > Matteo Beccati > > Development & Consulting - http://www.beccati.com/ > > -- > PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: > http://www.php.net/unsub.php