Re: cvs: php4 /ext/sockets sockets.c

On Mon, 2002-03-04 at 04:06, Jon Parise wrote: > On Mon, Mar 04, 2002 at 05:27:05AM -0000, Jason Greene wrote: > > > if (error < -10000) { > > error += 10000; > > + error=-error; > > Please attempt to retain the original style of the file you are > modifying. Jon, I do not appreciate the condescending tone of this comment. Yes I left out 2 white space characters, but allow me to make a few comments: First, you say that as if I completely disregarded style conformity. Did you bother reading the rest of this patch? Second, I am not finished with all of my updates (as stated in my commit message, and in a mail msg to php-dev outlining my changes). I have been debating on whether I should remove the whole -10000 range code. Third, Exactly which style of this file do you desire that I follow? (There is a mixture of old code, with the API rewrite) I think I have been contributing long enough to know the coding standards here. In the future I would much rather have a cordial reminder of a WS error then a remark such as this. -Jason