AW: [PHP-CVS] com php-src: Fix bug #73100 - Improve bug fix. Forbidto set 'user' save handler other than set_save_handler().:ext/session/php_session.h
ext/session/session.c ext/session/tests/bug60860.phptext/session/tests/bug73100.phpt ext/session/test

Hi Yasuo, I had a bit time to debug yesterday. It’s fixed now, please see the latest commit. Back to holidays now 😊 Regards Gesendet von meinem Windows 10 Phone Von: Yasuo Ohgaki Gesendet: Mittwoch, 28. Dezember 2016 07:20 An: Anatol Belski Cc: php-cvs@lists.php.net Betreff: Re: [PHP-CVS] com php-src: Fix bug #73100 - Improve bug fix. Forbidto set 'user' save handler other than set_save_handler().:ext/session/php_session.h ext/session/session.c ext/session/tests/bug60860.phptext/session/tests/bug73100.phpt ext/session/test Hi Anatol, On Tue, Dec 27, 2016 at 11:07 AM, Anatol Belski <anatol.php@belski.net> wrote: > There is still a failure in the TS run, even I've changed the test > > > https://ci.appveyor.com/project/php/php-src/build/master.build.152/job/laptrm6y031e11k3#L5606 > > It seems to me, there's an issue with the rev a93a51c3bf4ea1638ce0adc4a899cb93531b9f0d > and the module initialization order at least in the thread safe build. I did a short debug run, and > it shows, that in some case the E_RECOVERABLE_ERROR won't have any effect in > OnUpdateSaveHandler, or generally - in some INI handler. It depends on the module init order. The > related code is here > > > https://php-lxr.adamharvey.name/source/xref/master/main/main.c#1208 > > One can see, that the error handler won't bail out, if the full module initialization is > incomplete. AFM, it tells, that throwing such errors in the MINIT phase is not reliable. As the test > relies on the --INI-- section, that's the reason the exact behavior. IMO, if such error happens > in the MINIT phase, an error might be unreliable, for some reason the session module still gets > initialized :(. Maybe, the actual check should move into the later code, or there's a bug > elsewhere. Could you please take a further look? I'll be able to turn to this probably next > year at earliest. Thank you for checking. I'll look into to it. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net