Re: com php-src: Fix year dependent test: ext/date/tests/bug73426.phpt

On Sun, Jan 1, 2017 at 1:39 PM, Derick Rethans <derick@php.net> wrote: > On January 1, 2017 12:15:52 PM GMT+01:00, Nikita Popov <nikic@php.net> > wrote: > >Commit: 8467c5c9bff6f06f3aa79760fbd26684deb4bc11 > >Author: Nikita Popov <nikic@php.net> Sun, 1 Jan 2017 > >12:15:52 +0100 > >Parents: e51f284c783dcca59d131df85d052f0ff43714e3 > >Branches: PHP-7.1 master > > > >Link: > >http://git.php.net/?p=php-src.git;a=commitdiff;h= > 8467c5c9bff6f06f3aa79760fbd26684deb4bc11 > > > >Log: > >Fix year dependent test > > > >Changed paths: > > M ext/date/tests/bug73426.phpt > > > > > >Diff: > >diff --git a/ext/date/tests/bug73426.phpt > >b/ext/date/tests/bug73426.phpt > >index c2a700a..6f3b19e 100644 > >--- a/ext/date/tests/bug73426.phpt > >+++ b/ext/date/tests/bug73426.phpt > >@@ -4,12 +4,12 @@ Bug #73426 (createFromFormat with 'z' format char > >results in incorrect time) > > date.timezone=UTC > > --FILE-- > > <?php > >-$date = '12:00:00 15'; > >-$format = 'H:i:s z'; > >+$date = '2016 12:00:00 15'; > >+$format = 'Y H:i:s z'; > > var_dump(DateTime::createFromFormat($format, $date)); > > > >-$date = '16 12:00:00'; > >-$format = 'z H:i:s'; > >+$date = '16 12:00:00 2016'; > >+$format = 'z H:i:s Y'; > > var_dump(DateTime::createFromFormat($format, $date)); > > > > ?> > > Should this not be in 5.6 and 7 > 0 as well? > > cheers, > Derick > The test is only in 7.1+. I think the issue was related to microseconds, which is why it's not present in older branches. Regards, Nikita