Re: com php-src: These tests expect gc to be enabled: Zend/tests/gc_035.phpt Zend/tests/generators/gc_with_yield_from.phpt
| From: | Nikita Popov | Date: | Tue, 10 Jan 2017 16:59:29 +0000 |
| Subject: | Re: com php-src: These tests expect gc to be enabled: Zend/tests/gc_035.phpt Zend/tests/generators/gc_with_yield_from.phpt | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-96662@lists.php.net to get a copy of this message | ||
On Tue, Jan 10, 2017 at 5:54 PM, Rasmus Lerdorf <rasmus@php.net> wrote:
> Commit: 47fcb75a9074028440521412dce95bbec9ef5111
> Author: Rasmus Lerdorf <rasmus@php.net> Tue, 10 Jan 2017
> 11:54:49 -0500
> Parents: 3c23d1b6d52c3c818c6781e754db0d25ad36f4c8
> Branches: PHP-7.1
>
> Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=
> 47fcb75a9074028440521412dce95bbec9ef5111
>
> Log:
> These tests expect gc to be enabled
>
> Changed paths:
> M Zend/tests/gc_035.phpt
> M Zend/tests/generators/gc_with_yield_from.phpt
>
>
> Diff:
> diff --git a/Zend/tests/gc_035.phpt b/Zend/tests/gc_035.phpt
> index 985264c..177c310 100644
> --- a/Zend/tests/gc_035.phpt
> +++ b/Zend/tests/gc_035.phpt
> @@ -1,5 +1,7 @@
> --TEST--
> GC 035: Lost inner-cycles garbage
> +--INI--
> +zend.enable_gc = 1
> --FILE--
> <?php
> class A {
> diff --git a/Zend/tests/generators/gc_with_yield_from.phpt
> b/Zend/tests/generators/gc_with_yield_from.phpt
> index 8c05561..952352c 100644
> --- a/Zend/tests/generators/gc_with_yield_from.phpt
> +++ b/Zend/tests/generators/gc_with_yield_from.phpt
> @@ -1,5 +1,7 @@
> --TEST--
> Verify yield from on generators being properly cycle collected
> +--INI--
> +zend.enable_gc = 1
> --FILE--
> <?php
>
Should we maybe add zend.enable_gc to the force-enabled ini settings in
run-tests.php? I know there are many extension tests that depend on GC but
probably don't specify it.
Nikita