com php-src: Update comment, incorrect since 224aaf94: ext/session/session.c

Commit: 631861e1fa93b19788def94cf456d2993551c17f Author: SjonHortensius <SjonHortensius@users.noreply.github.com> Thu, 19 Jan 2017 11:41:02 +0100 Committer: Joe Watkins <krakjoe@php.net> Thu, 19 Jan 2017 10:48:54 +0000 Parents: 5e090311446819d9396b756ac33529c52220a8aa Branches: PHP-7.1 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=631861e1fa93b19788def94cf456d2993551c17f Log: Update comment, incorrect since 224aaf94 In 224aaf94; the warning was enabled; making the comment above incorrect. I've updated the comment to reflect the current code Changed paths: M ext/session/session.c Diff: diff --git a/ext/session/session.c b/ext/session/session.c index c06c5a3..d672b0c 100644 --- a/ext/session/session.c +++ b/ext/session/session.c @@ -425,8 +425,7 @@ static void php_session_initialize(void) /* {{{ */ php_session_track_init(); if (PS(mod)->s_read(&PS(mod_data), PS(id), &val, PS(gc_maxlifetime)) == FAILURE) { php_session_abort(); - /* Some broken save handler implementation returns FAILURE for non-existent session ID */ - /* It's better to raise error for this, but disabled error for better compatibility */ + /* FYI: Some broken save handlers return FAILURE for non-existent session ID, this is incorrect */ php_error_docref(NULL, E_WARNING, "Failed to read session data: %s (path: %s)", PS(mod)->s_name, PS(save_path)); return; }