com php-src: Fix bug #74603 - use correct buffer size: Zend/tests/bug74603.ini Zend/tests/bug74603.phpt Zend/zend_in i_parser.y
| From: | Stanislav Malyshev | Date: | Wed, 05 Jul 2017 02:35:56 +0000 |
| Subject: | com php-src: Fix bug #74603 - use correct buffer size: Zend/tests/bug74603.ini Zend/tests/bug74603.phpt Zend/zend_in i_parser.y | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-98352@lists.php.net to get a copy of this message | ||
Commit: 05255749139b3686c8a6a58ee01131ac0047465e
Author: Stanislav Malyshev <stas@php.net> Tue, 20 Jun 2017 00:09:01 -0700
Parents: 73cabfedf519298e1a11192699f44d53c529315e
Branches: PHP-7.0 PHP-7.1 master
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=05255749139b3686c8a6a58ee01131ac0047465e
Log:
Fix bug #74603 - use correct buffer size
Bugs:
https://bugs.php.net/74603
Changed paths:
A Zend/tests/bug74603.ini
A Zend/tests/bug74603.phpt
M Zend/zend_ini_parser.y
Diff:
diff --git a/Zend/tests/bug74603.ini b/Zend/tests/bug74603.ini
new file mode 100644
index 0000000..8d74a57
--- /dev/null
+++ b/Zend/tests/bug74603.ini
@@ -0,0 +1 @@
+0=0&~2000000000
diff --git a/Zend/tests/bug74603.phpt b/Zend/tests/bug74603.phpt
new file mode 100644
index 0000000..b3194ec
--- /dev/null
+++ b/Zend/tests/bug74603.phpt
@@ -0,0 +1,15 @@
+--TEST--
+Bug #74603 (PHP INI Parsing Stack Buffer Overflow Vulnerability)
+--SKIPIF--
+<?php
+if (PHP_INT_MAX !== 2147483647)
+ die('skip for 32-bit only');
+--FILE--
+<?php
+var_dump(parse_ini_file(__DIR__ . "/bug74603.ini", true, INI_SCANNER_NORMAL));
+?>
+--EXPECT--
+array(1) {
+ [0]=>
+ string(1) "0"
+}
diff --git a/Zend/zend_ini_parser.y b/Zend/zend_ini_parser.y
index e83f02f..f252581 100644
--- a/Zend/zend_ini_parser.y
+++ b/Zend/zend_ini_parser.y
@@ -55,7 +55,7 @@ static void zend_ini_do_op(char type, zval *result, zval *op1, zval *op2)
int i_result;
int i_op1, i_op2;
int str_len;
- char str_result[MAX_LENGTH_OF_LONG];
+ char str_result[MAX_LENGTH_OF_LONG+1];
i_op1 = atoi(Z_STRVAL_P(op1));
zend_string_free(Z_STR_P(op1));