Re: com php-src: Added support for controls to ldap_get_option: ext/ldap/ldap.c
| From: | Kalle Sommer Nielsen | Date: | Wed, 05 Jul 2017 19:26:29 +0000 |
| Subject: | Re: com php-src: Added support for controls to ldap_get_option: ext/ldap/ldap.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-98401@lists.php.net to get a copy of this message | ||
Hi Côme
2017-07-05 16:41 GMT+02:00 Côme Bernigaud <mcmic@php.net>:
> Commit: 3a09c1246cb5f084ffb00827d829d0da4f505c3c
> Author: Côme Chilliet <mcmic@php.net> Tue, 4 Jul 2017 17:08:57 +0200
> Parents: 6164ec91c6341f34e5a1d30c658c15ca9c5bcbaa
> Branches: master
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=3a09c1246cb5f084ffb00827d829d0da4f505c3c
>
> Log:
> Added support for controls to ldap_get_option
>
> Changed paths:
> M ext/ldap/ldap.c
>
>
> Diff:
> diff --git a/ext/ldap/ldap.c b/ext/ldap/ldap.c
> index 8e0b908..8263e70 100644
> --- a/ext/ldap/ldap.c
> +++ b/ext/ldap/ldap.c
> @@ -2129,6 +2129,8 @@ PHP_FUNCTION(ldap_sort)
> PHP_FUNCTION(ldap_get_option)
> {
> zval *link, *retval;
> + zval tmp1;
shouldn't these two be moved into the block for the option handling code?
--
regards,
Kalle Sommer Nielsen
kalle@php.net