com php-src: #73594 tests only check the extra params if dns_get_record is successful: ext/standard/tests/ne twork/bug73594.phpt
ext/standard/tests/network/bu g73594a.phpt

Commit: 2689917b17fd6018950b2af0711cb7fff702135d Author: Pedro Magalhães <mail@pmmaga.net> Sun, 9 Jul 2017 16:02:27 +0200 Committer: Joe Watkins <krakjoe@php.net> Mon, 10 Jul 2017 06:55:31 +0100 Parents: 5cf54f6073f9e3cfc99eca9e8a5706a08dd404a1 Branches: PHP-7.0 PHP-7.1 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=2689917b17fd6018950b2af0711cb7fff702135d Log: #73594 tests only check the extra params if dns_get_record is successful Bugs: https://bugs.php.net/73594 Changed paths: M ext/standard/tests/network/bug73594.phpt M ext/standard/tests/network/bug73594a.phpt Diff: diff --git a/ext/standard/tests/network/bug73594.phpt b/ext/standard/tests/network/bug73594.phpt index a306836..370b616 100644 --- a/ext/standard/tests/network/bug73594.phpt +++ b/ext/standard/tests/network/bug73594.phpt @@ -19,8 +19,9 @@ if (empty($out)) die("skip local resolver does not return additional records"); <?php $auth = array(); $additional = array(); -dns_get_record('php.net', DNS_MX, $auth, $additional); -var_dump(empty($additional)); +$res = dns_get_record('php.net', DNS_MX, $auth, $additional); +// only check $additional if dns_get_record is successful +var_dump(!empty($res) && empty($additional)); ?> --EXPECT-- bool(false) diff --git a/ext/standard/tests/network/bug73594a.phpt b/ext/standard/tests/network/bug73594a.phpt index a0a08e4..9a07fb7 100644 --- a/ext/standard/tests/network/bug73594a.phpt +++ b/ext/standard/tests/network/bug73594a.phpt @@ -18,8 +18,9 @@ if (empty($out)) die("skip local resolver does not return authority records"); --FILE-- <?php $auth = array(); -dns_get_record('php.net', DNS_MX, $auth); -var_dump(empty($auth)); +$res = dns_get_record('php.net', DNS_MX, $auth); +// only check $auth if dns_get_record is successful +var_dump(!empty($res) && empty($auth)); ?> --EXPECT-- bool(false)