Re: com php-src: Fixed bug #74878: NEWS Zend/zend_API.c

Using opcache we don't intern strings during compilation, only when we store script in SHM. I'll revert this for now. ________________________________ From: Nikita Popov <nikita.ppv@gmail.com> Sent: Monday, July 10, 2017 12:16:08 PM To: Dmitry Stogov Cc: Nikita Popov; php-cvs@lists.php.net; Sara Golemon Subject: Re: [PHP-CVS] com php-src: Fixed bug #74878: NEWS Zend/zend_API.c On Mon, Jul 10, 2017 at 10:08 AM, Dmitry Stogov <dmitry@zend.com<mailto:dmitry@zend.com>> wrote: This commit introduced a lot of memory leaks. Probably, you meant string interning only for internal classes. Even for internal classes only, this may require additional changes in opcache, that copies interned strings into shared memory. It's better to revert this, before complete fix. If this is causing issues, please revert it. I think it should always intern even for non-internal classes (these strings are likely duplicated compile-time strings, something we usually intern), but I clearly did not do it correctly. Nikita