com php-src: Fix check of mysql_commit() return value : ext/pdo_mysql/mysql_driver.c
| From: | Nikita Popov | Date: | Tue, 18 Jul 2017 19:45:02 +0000 |
| Subject: | com php-src: Fix check of mysql_commit() return value : ext/pdo_mysql/mysql_driver.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-98621@lists.php.net to get a copy of this message | ||
Commit: 51cdd3dc50af88461d83aec0fac1dca83400b58f
Author: YaoGuai <newtopstdio@163.com> Sun, 16 Jul 2017 15:12:29 +0800
Committer: Nikita Popov <nikita.ppv@gmail.com> Tue, 18 Jul 2017 21:45:02 +0200
Parents: 0da10134f2d0eedbe5603844932fc8a60616d1a6
Branches: PHP-7.0 PHP-7.1 PHP-7.2 master
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=51cdd3dc50af88461d83aec0fac1dca83400b58f
Log:
Fix check of mysql_commit() return value
For mysql_commit() everything non-zero is an error.
Changed paths:
M ext/pdo_mysql/mysql_driver.c
Diff:
diff --git a/ext/pdo_mysql/mysql_driver.c b/ext/pdo_mysql/mysql_driver.c
index 1bf4eb0..d505247 100644
--- a/ext/pdo_mysql/mysql_driver.c
+++ b/ext/pdo_mysql/mysql_driver.c
@@ -327,7 +327,7 @@ static int mysql_handle_commit(pdo_dbh_t *dbh)
PDO_DBG_ENTER("mysql_handle_commit");
PDO_DBG_INF_FMT("dbh=%p", dbh);
#if MYSQL_VERSION_ID >= 40100 || defined(PDO_USE_MYSQLND)
- PDO_DBG_RETURN(0 <= mysql_commit(((pdo_mysql_db_handle *)dbh->driver_data)->server));
+ PDO_DBG_RETURN(0 == mysql_commit(((pdo_mysql_db_handle *)dbh->driver_data)->server));
#else
PDO_DBG_RETURN(0 <= mysql_handle_doer(dbh, ZEND_STRL("COMMIT")));
#endif