com php-src: From documentation, only the sign of returned value is relevant: ext/standard/tests/strings/substr_compare.phpt

From: Date: Thu, 24 Aug 2017 08:27:38 +0000
Subject: com php-src: From documentation, only the sign of returned value is relevant: ext/standard/tests/strings/substr_compare.phpt
Groups: php.cvs 
Request: Send a blank email to php-cvs+get-99142@lists.php.net to get a copy of this message
Commit: b7e96f8e0ea2c241619ddf38cdde47abb7448823 Author: Remi Collet <remi@php.net> Thu, 24 Aug 2017 10:27:38 +0200 Parents: 4bf1a11c0711dad09c3f7e72062993efa0ec67ef Branches: PHP-7.0 PHP-7.1 PHP-7.2 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=b7e96f8e0ea2c241619ddf38cdde47abb7448823 Log: From documentation, only the sign of returned value is relevant With recent glibc, memcmp sometime return a negative value instead of -1 Changed paths: M ext/standard/tests/strings/substr_compare.phpt Diff: diff --git a/ext/standard/tests/strings/substr_compare.phpt b/ext/standard/tests/strings/substr_compare.phpt index c78dfca..4f69ee5 100644 --- a/ext/standard/tests/strings/substr_compare.phpt +++ b/ext/standard/tests/strings/substr_compare.phpt @@ -7,15 +7,15 @@ var_dump(substr_compare("abcde", "df", -2) < 0); var_dump(substr_compare("abcde", "bc", 1, 2)); var_dump(substr_compare("abcde", "bcg", 1, 2)); var_dump(substr_compare("abcde", "BC", 1, 2, true)); -var_dump(substr_compare("abcde", "bc", 1, 3)); -var_dump(substr_compare("abcde", "cd", 1, 2)); +var_dump(substr_compare("abcde", "bc", 1, 3) > 0); +var_dump(substr_compare("abcde", "cd", 1, 2) < 0); var_dump(substr_compare("abcde", "abc", 5, 1)); -var_dump(substr_compare("abcde", "abcdef", -10, 10)); +var_dump(substr_compare("abcde", "abcdef", -10, 10) < 0); var_dump(substr_compare("abcde", "abc", 0, 0)); var_dump(substr_compare("abcde", -1, 0, NULL, new stdClass)); echo "Test\n"; var_dump(substr_compare("abcde", "abc", 0, -1)); -var_dump(substr_compare("abcde", "abc", -1, NULL, -5)); +var_dump(substr_compare("abcde", "abc", -1, NULL, -5) > 0); var_dump(substr_compare("abcde", -1, 0, "str", new stdClass)); echo "Done\n"; @@ -25,12 +25,12 @@ bool(true) int(0) int(0) int(0) -int(1) -int(-1) +bool(true) +bool(true) Warning: substr_compare(): The start position cannot exceed initial string length in %s on line %d bool(false) -int(-1) +bool(true) int(0) Warning: substr_compare() expects parameter 5 to be boolean, object given in %s on line %d @@ -39,7 +39,7 @@ Test Warning: substr_compare(): The length must be greater than or equal to zero in %s on line %d bool(false) -int(4) +bool(true) Warning: substr_compare() expects parameter 4 to be integer, string given in %s on line %d bool(false)

« previous php.cvs (#99142) next »