RE: [PHP-CVS] cvs: php4 /ext/domxml php_domxml.c
| From: | Joseph Tate | Date: | Tue, 12 Mar 2002 15:43:06 +0000 |
| Subject: | RE: [PHP-CVS] cvs: php4 /ext/domxml php_domxml.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-9951@lists.php.net to get a copy of this message | ||
+1
> -----Original Message-----
> From: Christian Stocker [mailto:chregu@phant.ch]
> Sent: Tuesday, March 12, 2002 6:21 AM
> To: derick@php.net
> Cc: php-cvs@lists.php.net
> Subject: Re: [PHP-CVS] cvs: php4 /ext/domxml php_domxml.c
>
>
> Oops
>
> forgot to say, it segfaults only if you use the HEAD branch of ext/domxml
> in the 4_2_0 or 4_0_7 php-branch, this functions
> (domxml_doc_get_element_by_id) is not implemented in the 4_2_0 branch of
> ext/domxml, so no need to merge :)
>
> what i'd like to merge is the function domxml_elem_remove_attribute (as
> already requested by Daniel Allen)
>
> chregu
>
>
> On Tue, 12 Mar 2002 derick@php.net wrote:
>
> > On Tue, 12 Mar 2002, Christian Stocker wrote:
> >
> > > chregu Tue Mar 12 06:15:04 2002 EDT
> > >
> > > Modified files:
> > > /php4/ext/domxml php_domxml.c
> > > Log:
> > > forgot SEPARATE_ZVAL, produced segfaults.
> > > segfaulted only in 4_2_0 (not in HEAD and 4_0_7, strange...)
> >
> > Please merge this into the branch.
> >
> > Derick
> >
> > >
> > >
> > >
> > > Index: php4/ext/domxml/php_domxml.c
> > > diff -u php4/ext/domxml/php_domxml.c:1.126
> php4/ext/domxml/php_domxml.c:1.127
> > > --- php4/ext/domxml/php_domxml.c:1.126 Tue Mar 12 04:12:42 2002
> > > +++ php4/ext/domxml/php_domxml.c Tue Mar 12 06:15:03 2002
> > > @@ -16,7 +16,7 @@
> > >
> +----------------------------------------------------------------------+
> > > */
> > >
> > > -/* $Id: php_domxml.c,v 1.126 2002/03/12 09:12:42 mfischer Exp $ */
> > > +/* $Id: php_domxml.c,v 1.127 2002/03/12 11:15:03 chregu Exp $ */
> > >
> > > /* TODO
> > > * - Support Notation Nodes
> > > @@ -2378,7 +2378,7 @@
> > > xmlXPathObjectPtr xpathobjp;
> > > xmlNode *contextnodep;
> > > int name_len;
> > > - char *str,*name;
> > > + char *str, *name;
> > >
> > > contextnode = NULL;
> > > contextnodep = NULL;
> > > @@ -2423,9 +2423,10 @@
> > > xmlNodePtr node = nodesetp->nodeTab[0];
> > > int retnode;
> > > rv = php_domobject_new(node,
> &retnode TSRMLS_CC);
> > > + SEPARATE_ZVAL(&rv);
> > > }
> > > else {
> > > - /*return false array, if no nodes
> were found */
> > > + /*return false, if no nodes were found */
> > > RETURN_FALSE;
> > > }
> > >
> > >
> > >
> > >
> > > --
> > > PHP CVS Mailing List (http://www.php.net/)
> > > To unsubscribe, visit: http://www.php.net/unsub.php
> > >
> >
> > ----------------------------------------------------------------------
> > PHP: Scripting the Web - derick@php.net
> > All your branches are belong to me!
> > SRM: Site Resource Manager - www.vl-srm.net
> > -----------------------------------------------------------------------
> >
> >
> >
>
> --
> nam...christian stocker adr...bremgartnerstr. 66, ch-8003 zurich
> pho...+41 1 451 6021 www...http://phant.ch/chregu
> mob...+41 76 561 8860 ema...chregu@phant.ch
> wor...+41 1 240 5670 gpg...0x5CE1DECB
>
>
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php