com php-src: Fixed bug #75318 (The parameter of UConverter::getAliases() is not optional): NEWS ext/intl/converter/converter.c
ext/intl/tests/bug75318.phpt

Commit: ec3d864784aa14187ca20a7644ee78c813d8b744 Author: Christoph M. Becker <cmbecker69@gmx.de> Fri, 6 Oct 2017 16:45:07 +0200 Parents: 6b9ccda936bb863f9c9830f0aebef672a405a786 Branches: PHP-7.0 PHP-7.1 PHP-7.2 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=ec3d864784aa14187ca20a7644ee78c813d8b744 Log: Fixed bug #75318 (The parameter of UConverter::getAliases() is not optional) Of course, reflection has to know that as well. Bugs: https://bugs.php.net/75318 Changed paths: M NEWS M ext/intl/converter/converter.c A ext/intl/tests/bug75318.phpt Diff: diff --git a/NEWS b/NEWS index b68ad96..7079d81 100644 --- a/NEWS +++ b/NEWS @@ -17,6 +17,10 @@ PHP NEWS . Fixed bug #75311 (error: 'zend_hash_key' has no member named 'arKey' in apache2handler). (mcarbonneaux) +- Intl: + . Fixed bug #75318 (The parameter of UConverter::getAliases() is not + optional). (cmb) + - OCI8: . Fixed incorrect reference counting. (Dmitry, Tianfang Yang) diff --git a/ext/intl/converter/converter.c b/ext/intl/converter/converter.c index 5653b46..2b5cf98 100644 --- a/ext/intl/converter/converter.c +++ b/ext/intl/converter/converter.c @@ -897,7 +897,7 @@ static PHP_METHOD(UConverter, getAvailable) { /* }}} */ /* {{{ proto array UConverter::getAliases(string name) */ -ZEND_BEGIN_ARG_INFO_EX(php_converter_getaliases_arginfo, 0, ZEND_RETURN_VALUE, 0) +ZEND_BEGIN_ARG_INFO_EX(php_converter_getaliases_arginfo, 0, ZEND_RETURN_VALUE, 1) ZEND_ARG_INFO(0, name) ZEND_END_ARG_INFO(); static PHP_METHOD(UConverter, getAliases) { diff --git a/ext/intl/tests/bug75318.phpt b/ext/intl/tests/bug75318.phpt new file mode 100644 index 0000000..7235846 --- /dev/null +++ b/ext/intl/tests/bug75318.phpt @@ -0,0 +1,15 @@ +--TEST-- +Bug #75318 (The parameter of UConverter::getAliases() is not optional) +--SKIP-- +<?php +if (!extension_loaded('intl')) die('skip intl extension is not available'); +?> +--FILE-- +<?php +$rm = new ReflectionMethod('UConverter', 'getAliases'); +var_dump($rm->getNumberOfRequiredParameters()); +?> +===DONE=== +--EXPECT-- +int(1) +===DONE===