Re: 3.0.12: mysql_store_result in php3_mysql_query

Hrm.. That does look a bit odd. This change was made Friday, October 24, 1997 by Zeev. I am sure he remembers why he made the change! ;) See http://cvs.php.net/cvsweb.cgi/functions/mysql.c and go down to the 1.41 change. Zeev's comment just says, "Fixed a free() that should have been efree() on a failed mysql_connect()" which doesn't really seem to relate to this particular change. On Thu, 2 Sep 1999, David Sklar wrote: > > I have a page that does: > > $r = mysql_query('select ping from ping'); > if ($r) { > if ($ob = mysql_fetch_object($r)) { > echo $ob->ping."\n"; > } else { > echo "Can't get ob\n"; > } > } else { > echo "Can't do query\n"; > } > > Very infrequently, when accessing this page, I get a "PHP 3 Warning: 1 is not > a MySQL result index" at the line with mysql_fetch_object(). So mysql_query is > returning 1 (or TRUE that gets evaluated to 1?) but it's still not really a > result handle. > > Could the following code in php3_mysql_query() be responsible: ? > > if ((mysql_result=mysql_store_result(mysql))==NULL) { > /*php3_error(E_WARNING,"Unable to save MySQL query result"); > RETURN_FALSE; > */ > RETURN_TRUE; > } > > > Why is it returning true if there was an error? mysql_store_result() returns > NULL if an error occurs. > > > -dave > > > > >