Re: Bug#44357: php3: zlib support breaks $PHP_INCLUDE_PATH [patch] (fwd)
| From: | Patrik Rak | Date: | Mon, 06 Sep 1999 10:57:03 +0000 |
| Subject: | Re: Bug#44357: php3: zlib support breaks $PHP_INCLUDE_PATH [patch] (fwd) | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-10612@lists.php.net to get a copy of this message | ||
On Mon, 6 Sep 1999, Gergely Madarasz wrote:
> Hello,
>
> I just got this report and patch in the debian BTS. Could you please
> comment on it ?
Sure.
PHP interpreter (both apache module and standalone program) maintains
an internal structure which holds all of the configuration variables
(actually, it maintains two copies of this structure, but I'll simplify
here - let me know if you need more details).
This structure is filled with data from php3.ini file and/or from
environment variables and should not be changed afterwards.
However, the zlib "module" reinitializes some of the configuration
variables, but takes only the ini file into account and disregards the
environment vars. It seems that in the past it used its
own private configuration structure but from some point it started to use
the global php3 config structure. It uses the ZLIB_INI() macro to access
this config structure. Nevertheless, the initialization code does not care
of what structure is really used.
The whole point of the patch is to skip the initialization of the
config structure in case the (already initialized) global php3 structure
is used.
Note that the whole part of global/custom structure might be obsolete and
can be completely removed. On the other hand, it might be still used for
development purposes. You'll have to ask upstream about it. I just did the
least necessary change to make things work without breaking anything.
Patrik