Re: cvs: /php3 ChangeLog /php3/functions file.c php3_string.h

On Mon, 20 Sep 1999, Rasmus Lerdorf wrote: > > Then if it's ok, we'll use the lex file and either make a new function, > > or incorporate it into htmlspecialchars.. > > > > any suggestions? > > I guess my main concern is that using flex for something this simple is > rather drastic. ie. > > -rw-r--r-- 1 rasmus users 1561 Sep 17 13:57 tagquoter.lex > -rw-r--r-- 1 rasmus users 39360 Sep 20 14:20 lex.tagquoter_yy.c > -rw-r--r-- 1 rasmus users 12588 Sep 20 14:21 lex.tagquoter_yy.o > > A full 12K of object code for this? The logic I added to strip_tags > probably amounted to less than 500 bytes and it does the same thing. Did you check that? Objects have a fairly big header and added information. Also remember that the type of code you're playing with is extremely prone to bugs (before your addition and especially after it), whereas flex generated code is rock solid and very easily modified. It's usually worth the few added kilobytes. Zeev -- ----------------------------------------------------- Zeev Suraski <zeev@zend.com> http://www.zend.com/ For a PGP public key, finger bourbon@netvision.net.il