PHP 4.0 Bug #2367: configures puts -I/usr/include in CFLAGS, breaks gcc varargs

From: mark@jumpweb.com Operating system: Solaris 2.7 PHP version: 4.0 Beta 2 PHP Bug Type: Compile Failure Bug description: configures puts -I/usr/include in CFLAGS, breaks gcc varargs The standard configure script can put -I/usr/include in CLFAGS. This happens on Solaris if LDAP is installed since it finds ldap.h in /usr/include, but can happen anywhere certain optional packages are installed in /usr/include. Having -I/usr/include is generally a bad thing. It specifically breaks gcc on Solaris 2.7 on the __builtin_avalist stuff in stdarg.h and has the potential to break any compiler that has "private" include directories ahead of /usr/include. Fixing every case would be a pain, it might be easiest to have something like --allow-dashi-usr-include or --no-dashi-usr-include to allow stripping out any -I/usr/includes after @INCLUDES@ is finished being defined. Note the configure script also is vulnerable to similar problems with -L/usr/lib as far as I can tell and again, generally a -L/usr/lib is a bad thing.