cvs: /php3 ChangeLog control_structures_inline.h
| From: | Thies C. Arntzen | Date: | Wed, 13 Oct 1999 14:10:10 +0000 |
| Subject: | cvs: /php3 ChangeLog control_structures_inline.h | ||
| Groups: | php.dev | ||
| Request: | Send a blank email to php-dev+get-11718@lists.php.net to get a copy of this message | ||
thies Wed Oct 13 10:10:10 1999 EDT
Modified files:
/php3 ChangeLog control_structures_inline.h
Log:
backquote opened shell commands would create zombies!
# i simply cannot believe that this bug hasen't been found yet!
Index: php3/ChangeLog
diff -u php3/ChangeLog:1.778 php3/ChangeLog:1.779
--- php3/ChangeLog:1.778 Fri Oct 8 00:51:52 1999
+++ php3/ChangeLog Wed Oct 13 10:10:09 1999
@@ -2,6 +2,7 @@
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
???? ??, 1999, Version 3.0.13
+- Fixed zombie problem when using backquotes. eg: $x =
ls /; (Thies)
- Locale settings are restored correctly at request end if they
were changed in the script (Jouni)
- Fixed wrong values returned by gmmktime() and its inconsistent behaviour.
Index: php3/control_structures_inline.h
diff -u php3/control_structures_inline.h:1.200 php3/control_structures_inline.h:1.201
--- php3/control_structures_inline.h:1.200 Fri Jul 16 14:04:59 1999
+++ php3/control_structures_inline.h Wed Oct 13 10:10:09 1999
@@ -29,7 +29,7 @@
*/
-/* $Id: control_structures_inline.h,v 1.200 1999/07/16 18:04:59 jim Exp $ */
+/* $Id: control_structures_inline.h,v 1.201 1999/10/13 14:10:09 thies Exp $ */
#ifdef THREAD_SAFE
#include "tls.h"
@@ -1439,7 +1439,7 @@
allocated_space = total_readbytes+EXEC_INPUT_BUF;
result->value.str.val = (char *) erealloc(result->value.str.val,allocated_space);
}
- fclose(in);
+ pclose(in);
result->value.str.val = erealloc(result->value.str.val,total_readbytes+1);
result->value.str.val[total_readbytes]=0;