Re: Re: [PHP4BETA] cvs: /php4/ext/imap imap.c
| From: | Mark Musone | Date: | Mon, 01 Nov 1999 16:36:50 +0000 |
| Subject: | Re: Re: [PHP4BETA] cvs: /php4/ext/imap imap.c | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-12064@lists.php.net to get a copy of this message | ||
uhhhh......yes?
seriously, i think it was probably a typo..from the CVS log:
revision 1.31
date: 1998/09/04 04:28:32; author: musone; state: Exp; lines: +109 -6
fixed imap_sort and added a beta imap_bodystruct
I dont think i ever finished it (expecially since i havent even documented it yet..)
i just commited the fix..
Mark
>
> > Quoting Rasmus Lerdorf <rasmus@php.net>:
> >
> > > if ( body->id ){
> > > add_property_long( return_value, "ifid", 1 );
> > > - if(body->description) add_property_string( return_value, "id",
> > > body->description, 1 );
> > > + if(body->description) add_property_string( return_value, "id",
> > > body->id, 1 );
> > > } else {
> > > add_property_long( return_value, "ifid", 0 );
> > > }
> >
> > I'm a bit confused about the logic here. Why should body->description be
> > checked at all - if body->id is there, it should be used. Or am I missing
> > something?
>
> No idea. body->description is checked all over. Who wrote this
> function? Mark perhaps? I think we need some insight.
>
> -Rasmus
>
>
> --
> PHP Development Mailing List <http://www.php.net/>
> To unsubscribe, e-mail: php-dev-unsubscribe@lists.php.net
> For additional commands, e-mail: php-dev-help@lists.php.net
> To contact the list administrators, e-mail: php-list-admin@lists.php.net
>