Bug #2788: urldecode bug

From: hsheo@postech.ac.kr Operating system: RedHat 6.0 PHP version: 3.0.12 PHP Bug Type: Other Bug description: urldecode bug --- php-4.0b3/ext/standard/url.c.orig Sun Nov 21 23:30:07 1999 +++ php-4.0b3/ext/standard/url.c Sun Nov 21 23:38:59 1999 @@ -297,9 +297,14 @@ var_reset(return_value); return; } - len = _php3_urldecode((*arg)->value.str.val, (*arg)->value.str.len); - RETVAL_STRINGL((*arg)->value.str.val, len, 1); + { char *str; /* Heo Hee-Seok: Bug fix */ + str = (char *) emalloc((*arg)->value.str.len + 1); + strncpy(str, (*arg)->value.str.val, (*arg)->value.str.len + 1); + len = _php3_urldecode(str, (*arg)->value.str.len); + + RETVAL_STRINGL(str, len, 1); + efree(str); } } /* }}} */