Re: Proposed change to main.c
| From: | Joey | Date: | Tue, 14 Dec 1999 18:52:53 +0000 |
| Subject: | Re: Proposed change to main.c | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-13696@lists.php.net to get a copy of this message | ||
> Which compiler are you using? Declaring variables like this is bound to
> cause compatibility problems. emalloc() your storage instead.
>
>
> 3rd argument to strlcat() should be amount of free space left, not how
> many characters to copy.
>
> Have you tested all this?
>
> You might just want to send me the corrected patch and I'll add it after
> review along with the .ini option that controls this behavior.
>
> -Andrei
> * Ethernet n.: something used to catch the etherbunny. *
See, I /KNEW/ it couldn't be that easy...it compiles for me, and I used
error_log() to test it, and it works, but it just seemed to easy! :)
I'll send you the corrected patch later today...thanks for looking over it
for me.