Re: [PHP4BETA] Re: [PHP-DEV] $string != $array should throw a warning!

By the way, what we probably need to do is change var_reset() in zend_variables.c to return BOOL(0) and also do a quick search on the whole PHP tree. Some modules initialize their return values on failure to IS_STRING:empty_string but I guess now BOOL:0 would be more appropriate. We should probably change these modules to just call var_reset() in those places. Can anyone think of what problems might arise when doing this? Would we break any backwards compatibility? I don't like the idea of having a false return value sometimes be the empty_string and sometimes BOOL(0). It should always be BOOL(0). Andi At 10:16 PM 12/28/99 +0200, Andi Gutmans wrote:

On Tue, 28 Dec 1999, Thies C. Arntzen wrote: On Tue, 28 Dec 1999, Andi Gutmans wrote:

Yeah they should be bool in my opinion too. How about entering it in bugs.php.net/version4 so that we remember to fix it.

andi, the fix is too easy to put it in bugdb, question is how do we want to fix it: a) spit a warning in compare-function & still return var_reset()? We should be returning false (bool(0)) in these functions. We'll have to hold a vote if we should spit out a warning or not. I think we should because it's a coding error. b) decide if array > string or vice versa No we don't want this kind of unintuitive stuff in PHP. It is undefined as far as I'm concerned. just have a quick look at compare_function and you'll see what i mean. as the current behaviour is undefined i'd go for b) and declare "Array > string" (that was choosen by random), 'cause i don't like the idea of an basic operator to spit a warning. comments? -- PHP 4.0 Beta Mailing List <http://www.php.net/version4/> To unsubscribe, e-mail: php4beta-unsubscribe@lists.php.net For additional commands, e-mail: php4beta-help@lists.php.net To contact the list administrators, e-mail: php4beta-admin@lists.php.net

--- Andi Gutmans <andi@zend.com> http://www.zend.com/