GD/JPEG support in PHP4
| From: | Sander Steffann | Date: | Sat, 18 Mar 2000 22:48:28 +0000 |
| Subject: | GD/JPEG support in PHP4 | ||
| Groups: | php.dev | ||
| Request: | Send a blank email to php-dev+get-17007@lists.php.net to get a copy of this message | ||
Hi,
I was looking at the JPEG support in PHP4 (CVS), and I noticed the following
code in config.m4:
old_LIBS=$LIBS
LIBS="$LIBS -L$withval/lib"
AC_CHECK_LIB(jpeg,jpeg_read_header,
[LIBS="$LIBS -L$withval/lib -ljpeg"],[AC_MSG_RESULT(no)],)
LIBS=$old_LIBS
AC_ADD_LIBRARY_WITH_PATH(jpeg, $withval/lib)
LIBS="$LIBS -L$withval/lib -ljpeg"
Is it me, or is this code a little odd?
Another thing:
It only checks for JPEG support happen in the case that $withval=yes. When a
path is supplied, AC_DEFINE(HAVE_GD_JPG, 1, [ ]) can never happen...
Isn't it time to clean this code up? When there are reasons to leave the
code as it is, please tell me. Otherwise I'll try to write a cleaned-up
version.
Sander.