Re: Re: Strange change
| From: | Rasmus Lerdorf | Date: | Sun, 19 Mar 2000 22:20:20 +0000 |
| Subject: | Re: Re: Strange change | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-17062@lists.php.net to get a copy of this message | ||
> On Mon, 20 Mar 2000, Rasmus Lerdorf wrote:
> > Andrei, could you explain your logic behind this patch?
> >
> > ƒ®ÌçÁâê
> > ©ªâ§<@http://cvsweb.php.net/cvsweb.cgi/functions/exec.c.diff?r1=1.88&r2=1.89
> >
> > It is the reason something like:
> >
> > <?
> > echo exec("pwd");
> > ?>
> >
> > no longer prints anything.
>
> I don't know, your example prints everything fine for me. Those lines
> were removed because they were returning a buffer with undefined
> contents.
Well, it would return everything fine for you assuming you have
magic_quotes_runtime turned on. You removed the else clause that returns
the string in case magic_quotes_runtime is not turned on. That makes no
sense to me. If the buffer really is invalid, which my gdb trace does not
agree with, then both RETVAL_STRINGL() calls should have been
removed.
-Rasmus