PHP 4.0 Bug #4201 Updated: ImageCreateFromPNG("/dev/null") crashes (Segfault)
| From: | Bug Database | Date: | Thu, 20 Apr 2000 17:28:13 +0000 |
| Subject: | PHP 4.0 Bug #4201 Updated: ImageCreateFromPNG("/dev/null") crashes (Segfault) | ||
| Groups: | php.dev | ||
| Request: | Send a blank email to php-dev+get-18062@lists.php.net to get a copy of this message | ||
ID: 4201
User Update by: flebarbe@ocare.com
Status: Open
Bug Type: Reproduceable crash
Description: ImageCreateFromPNG("/dev/null") crashes (Segfault)
Here's the patch...
-----------------------------------------------------------------------------
--- gd.c.orig Wed Apr 19 12:27:40 2000
+++ gd.c Wed Apr 19 14:00:48 2000
@@ -460,6 +460,10 @@
fflush(fp);
fclose(fp);
+ if (!im) {
+ php_error(E_WARNING,"ImageCreateFromPng: %s is not a valid PNG file", fn);
+ RETURN_FALSE;
+ }
ZEND_REGISTER_RESOURCE(return_value, im, GDG(le_gd));
}
/* }}} */
@@ -570,6 +574,10 @@
fflush(fp);
fclose(fp);
+ if (!im) {
+ php_error(E_WARNING,"ImageCreateFromGif: %s is not a recognized GIF file",
fn);
+ RETURN_FALSE;
+ }
ZEND_REGISTER_RESOURCE(return_value, im, GDG(le_gd));
}
/* }}} */
@@ -683,6 +691,10 @@
fflush(fp);
fclose(fp);
+ if (!im) {
+ php_error(E_WARNING,"ImageCreateFromJPEG: %s is not a recognized JPEG
file", fn);
+ RETURN_FALSE;
+ }
ZEND_REGISTER_RESOURCE(return_value, im, GDG(le_gd));
}
/* }}} */
Full Bug description available at: http://bugs.php.net/version4/?id=4201