Re: sscanf() and fscanf() ready for testing.

Andi, > You fill in the CVS submission form at > http://www.php.net/cvs-php3.php i filled in the application for CVS access. still waiting for a response .... > Just from your description I'm not sure your approach was the right one. > sscanf() should not be a copy of 99% of the code in fscanf() but if > possible the code should be generalized so that sscanf() and fscanf() can > both use the same code. How difficult is this? (I haven't actually looked > at the code myself). It would make maintenance much easier and if someone > fixes a bug or feature in fscanf() (or vice versa) it would automatically > fix sscanf(). > sorry i was unclear. i meant exactly what you explained. there is a common routine php_sscanf_internal which does all the dirty work for both fscanf() and sscanf(). all both routines need to do is pass it parameters. > Where is the fscanf() implementation? I don't see it in the source tree (I > must be not looking well enough). > like i said, just waiting to be granted access. if you'd like, i can either attach it to a message or email it to you... clayton