Re: CVS Account Request

Amit, We always can do with more help especially bug fixes/improvements. Things work on a voluntary basis and the easiest way to join in is to be on the php-dev mailing list and start helping out. I added your suggestion to the current PHP CVS tree. Thanks, Andi At 10:50 AM 7/1/00 +0200, Amit Schreiber wrote:

Hello, Here's a quote of what I sent to group@php.net, as requested on PHP's site: <QUOTE> Hi there, My name is Amit Schreiber. I'm a student at the Technion, Israel. I'll be starting my third year of mathematics and computer-science studies pretty soon. I'm a lot better in programming than I am in math :) I've used PHP for one big project so far. I really liked using it, and since I've been wanting to join an open-source project for a while now, I thought it would be great to join the PHP group. Altough I'm not sure about how much I can contribute in the development of PHP, I'm sure I can help with something, like code reviewing, or testing. If there's a bug, and I'm sent to hunt it, I believe I can do it, too. For example, after reviwing some of PHP/Zend's code (just to get familiar with the style) I came across these few lines (image.c:line 405): if (result) { if (array_init(return_value) == FAILURE) { php_error(E_ERROR, "Unable to initialize array"); if (result) efree(result); return; } /* ..... */ } There are two "if (result)" checks. It seems the second is not neccesary, and is probably there because of legacy code. I truly believe such comments (if found true) can be useful to a project, no matter how unimportant they may seem. I hope you'll find me useful, and let me join the development process, as a code reviewr / bug hunter / whatever. I have both Windows and Linux installed on my computer, but I'm really new to Linux. I'm familiar with (and have installed) Visual C++ 6. Thanks in advance, Amit. </QUOTE> ----- Original Message ----- From: "Rasmus Lerdorf" <rasmus@linuxcare.com> To: <gnobal@yahoo.com> Sent: Friday, June 30, 2000 6:43 PM Subject: Re: CVS Account Request Please send a blurb about what you want to work on in PHP to php-dev@lists.php.net -Rasmus -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, e-mail: php-dev-unsubscribe@lists.php.net For additional commands, e-mail: php-dev-help@lists.php.net To contact the list administrators, e-mail: php-list-admin@lists.php.net

--- Andi Gutmans <andi@zend.com> http://www.zend.com/