PHP 4.0 Bug #5407: gmmktime's add "gmajust" but it's upside down
| From: | sagawa at sohgoh dot net | Date: | Thu, 06 Jul 2000 14:53:14 +0000 |
| Subject: | PHP 4.0 Bug #5407: gmmktime's add "gmajust" but it's upside down | ||
| Groups: | php.dev | ||
| Request: | Send a blank email to php-dev+get-23595@lists.php.net to get a copy of this message | ||
From: sagawa@sohgoh.net
Operating system: All?
PHP version: 4.0.1pl2
PHP Bug Type: Misbehaving function
Bug description: gmmktime's add "gmajust" but it's upside down
In datetime.c
line 177
seconds += gmadjust;
shoud be
seconds -= gmadjust;
In old PHP (<=3.0.6?),
subtract gmadjust from seconds.
So this is correct way, I think.
ref.
o Diffs between 1.60 and 1.61
http://cvs.php.net/viewcvs.cgi/php3/functions/datetime.c.diff?r1=1.60&r2=1.61