Bug #858 (attn: Stig)
| From: | Rasmus Lerdorf | Date: | Thu, 01 Jan 1970 00:00:00 +0000 |
| Subject: | Bug #858 (attn: Stig) | ||
| Groups: | php.dev | ||
| Request: | Send a blank email to php-dev+get-2377@lists.php.net to get a copy of this message | ||
Stig, could you take a quick look at bug #858. sprintf() is your baby and
the claim is that an empty string argument to a %s is causing a core dump
(I think). I can't reproduce that here.
Perhaps it could be this bit of code:
case 's':
convert_to_string(args[currarg]);
_php3_sprintf_appendstring(&result, &outpos, &size,
args[currarg]->value.str.val,
width, precision, padding,
alignment);
break;
that needs a check for args[currarg]->value.str.len being 0 ?
Also, I noticed that in _php3_sprintf_appendstring() you do a strlen() on
the string argument being passed in. Why not pass in
args[currarg]->value.str.len and give sprintf() a chance of being binary
safe?
-Rasmus
--
PHP Development Mailing List http://www.php.net/
To unsubscribe send an empty message to php-dev-unsubscribe@lists.php.net
For help: php-dev-help@lists.php.net