Re: [PHP3] Changes in REgex lib in 3.0.5

> What changes if any were made in the regex lib or associated function in > version > 3.0.5. Several people are reporting having problems with phorum after > updating to this version. If you look at cvs.php.net/cvsweb.cgi/functions/reg.c you will see that absolutely nothing changed between version 3.0.4 and 3.0.5. You can tell this from the fact that the file carries both tags. And the underlying regex bundled regex library hasn't changed at all since 3.0a2. And if they are upgrading from a version prior to that then there were three changes since version 3.0. The change between 3.0 and 3.0.1 was a simple renaming of some internal hasheing functions which could not possibly affect things. Between 3.0.1 and 3.0.4 three things changed. Zeev made these changes to reg.c: @@ -188,7 +188,7 @@ - entry.value.str.val = estrdup(buf); + entry.value.str.val = estrndup(buf, entry.value.str.len); @@ -179,7 +179,7 @@ - yystype_destructor(array _INLINE_TLS); /* start with clean array */ + pval_destructor(array _INLINE_TLS); /* start with clean array */ and I made this one: @@ -540,8 +540,8 @@ - tmp[i*4+1]=toupper(string->value.str.val[i]); - tmp[i*4+2]=tolower(string->value.str.val[i]); + tmp[i*4+1]=toupper((unsigned char)string->value.str.val[i]); + tmp[i*4+2]=tolower((unsigned char)string->value.str.val[i]); I don't see anything inherently wrong with any of these. Any chance you could narrow down exactly the part of your script that is not behaving as expected and send us a short example that illustrates the problem? And also, let us know which version they are upgrading from. There really wasn't very much done between 3.0.4 and 3.0.5 that would affect anything. From 3.0.3 to 3.0.4 quite a bit was changed though. -Rasmus -- PHP Development Mailing List http://www.php.net/ To unsubscribe send an empty message to php-dev-unsubscribe@lists.php.net For help: php-dev-help@lists.php.net