Re: UPDATED: Patch to fix BUG: ldap_search: sizelimit exceeded, no result..

On Thu, 20 Jul 2000, Stig Venaas wrote: >OK, I see, sorry if I was a bit harsh. Well, perhaps I didn't explain this well enough in my first post..=) >Just one small point, the C API also allows for getting just the attributes, >this is something that might be useful, at leat I have an application where >it could be used. The C API is like > > int ldap_search( > LDAP *ld, > char *base, > int scope, > char *filter, > char *attrs[], > int attrsonly >where ld can also specify sizelimit, timelimit and deref. I wonder why those weren't implemented already in the php-ldap?? BTW. There's comment in ldap.c about attrsonly: /* Is it useful to only get the attributes ? */ attrsonly = 0; =) >Wouldn't it be better if we changed ldap_search into >int ldap_search (int link_identifier, string base_dn, string filter >[, array attributes, int attrsonly, int sizelimit, int timelimit, int deref]) >What do you and others think of that? This is a good thing (tm) and really should be done. I'll look into it today. >In short, I think your patch is useful and should be added (haven't studied >the code though), but I want attrsonly to be added at the same time. That's >done in a minute. I'll do it myself if you don't. I will try.. If I get it done, I'll sent the patch for you today and you can then verify it. >Unless anyone else does, I'll apply your patch and possible additions in >a day or two, I'm a bit busy right now. Aren't we all? =) --Jani