Re: ODBC Problem

Just for clarification - I am NOT trying to comment on coding :-) There's a hell of a lot of work gone in to PHP and the odd error is bound to occur now and then... But the fault I revered to was in 3.0.5 the code was len = strlen(db) + strlen(uid) + strlen(pwd) + 9; (line 1623) in the newer version it was len = strlen(db) + strlen(uid) + strlen(pwd) + strlen(UODBC_NAME) + 4;(line 1762) The 3.0.5 allocation allowed for the NULL terminator on the string, the newer length didn't. Steve Rasmus Lerdorf wrote: > Actually, since Shane is likely to get more flack on this one. To be fair > to him this problem was introduced before those large changes. The actual > patch that introduced the bug is: > > > http://cvs.php.net/cvsweb.cgi/functions/unified_odbc.c.diff?r1=1.78&r2=1.79&f=h > > This means that it has been in the code since September 14 and appeared in > 3.0.4. Shane's major ODBC layout changes didn't happen until October 29 > and were included in 3.0.5. > > Just clarifying this since Shane took some heat over that large patch. > Note that both patches were his, so we can still beat on him! ;) > > By the way, nice work tracking this one down Steve. I spent some time > looking at the changes since 3.0.5 and really couldn't see anything that > would have cuased the problems you described. Turns out I didn't go back > far enough. Since this problem has been in the code since 3.0.4 I am > quite surprised that nobody has reported it. > -- Steve Williams Interactive Media & Tools Group Empress Software Inc. http://www.empress.com -- PHP Development Mailing List http://www.php.net/ To unsubscribe send an empty message to php-dev-unsubscribe@lists.php.net For help: php-dev-help@lists.php.net