Re: Re: PHP 4.0 Bug #5882 Updated: Use inline directive in *.c files for global functions in Zend engine

> Wait, before applying that patch I would like to understand what's > happening here. Don't worry, it is broken anyway. > In gcc the previous way works, right? In C99, if you put the extern keyword > it still won't inline those functions right? If they are moved to an .h > file then gcc will probably complain about multiple declerations? > If all of the above is true, maybe these inline functions should be moved > to an .h file which we'll #include in zend_gcc_inline.c? If your intention is to make all these functions generally available as inline functions, we need to move them to the header file (as we did in the past). The current problem is that some compilers interprete the inline functions in zend_API.c as auxiliary inline functions with internal linkage, so that they are not exported from that object file. > Damn, it used to be C++ which wasn't standardized enough and now C is being > attacked. Although maybe some of the changes are good it's quite annoying. Well, over the time, inline had three different semantics in C++. Let us hope that the first try at standardizing the use of inline in C succeeds. - Sascha