safe_mode and ENFORCE_SAFE_MODE
| From: | Andi Gutmans | Date: | Sat, 19 Aug 2000 00:16:14 +0000 |
| Subject: | safe_mode and ENFORCE_SAFE_MODE | ||
| Groups: | php.dev | ||
| Request: | Send a blank email to php-dev+get-29608@lists.php.net to get a copy of this message | ||
Hey,
Any idea why php_fopen_wrapper() accepts the ENFORCE_SAFE_MODE option?
Shouldn't it just check PG(safe_mode) like it does in most places? This means that places that call php_fopen_wrapper() and don't explicitly pass the ENFORCE_SAFE_MODE option aren't really safe_mode'ed even under safe_mode. It makes little sense.
As far I'm concerned PG(safe_mode) is what should be checked ALWAYS. When safe_mode is on it should effect all of PHP. Does anyone see any problems with this? If not I will make the change.
Another thing is why do we still have the --enable-safe-mode compile switch? safe_mode can be set by the system php.ini file. No code as far as I saw actually gives a shit about the PHP_SAFE_MODE being defined by ./configure. IMO yet another thing we can nuke.
Please give feedback on this issue ASAP.
Thanks,
Andi
---
Andi Gutmans <andi@zend.com>
http://www.zend.com/