Re: realpath function
| From: | Andi Gutmans | Date: | Sat, 19 Aug 2000 22:05:34 +0000 |
| Subject: | Re: realpath function | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-29725@lists.php.net to get a copy of this message | ||
php_realpath() shouldn't really be used anymore. You should use expand_filepath() from fopen-wrappers.c. So your patch is wrong.
Your second patch is also wrong. The virtual_utime() needs to call the real utime(). That's the whole idea. What problems are you encountering?
Andi
At 12:54 AM 8/20/00 +0300, Zeev Suraski wrote:
Did you test the latest CVS? At least the realpath problem was supposed to be gone, I fixed it this afternoon... As for utime(), I think it's ok (Andi should answer this), and at any rate, it seems we need errno.h in order to make VC++ happy without warnings. Zeev At 22:08 19/08/2000, Frank M. Kromann wrote:-- Zeev Suraski <zeev@zend.com> http://www.zend.com/ -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, e-mail: php-dev-unsubscribe@lists.php.net For additional commands, e-mail: php-dev-help@lists.php.net To contact the list administrators, e-mail: php-list-admin@lists.php.net --- Andi Gutmans <andi@zend.com> http://www.zend.com/Hi All, In order to compile php4dll.dll and php4dllts.dll I have made the folowing changes: =================================================================== RCS file: /repository/php4/main/php.h,v retrieving revision 1.111 diff -r1.111 php.h 336c336 < #define V_REALPATH(path,real_path) realpath(path,real_path) ---#define V_REALPATH(path,real_path) php_realpath(path,real_path)=================================================================== RCS file: /repository/php4/main/php_virtual_cwd.h,v retrieving revision 1.32 diff -r1.32 php_virtual_cwd.h 47,50c47,48 < #if HAVE_UTIME < # ifdef PHP_WIN32 < # include <sys/utime.h> < # endif ---#ifdef PHP_WIN32 # include <sys/utime.h>Index: php_virtual_cwd.c =================================================================== RCS file: /repository/php4/main/php_virtual_cwd.c,v retrieving revision 1.66 diff -r1.66 php_virtual_cwd.c 504c504< ret = utime(new_state.cwd, buf);---ret = V_UTIME(new_state.cwd, buf);I'm note sure if this will have an unwanted side effect. If not I'll commit the changes. - Frank -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, e-mail: php-dev-unsubscribe@lists.php.net For additional commands, e-mail: php-dev-help@lists.php.net To contact the list administrators, e-mail: php-list-admin@lists.php.net