Re: SAPI.c: strange strlcpy logic

From:	Andi Gutmans	Date:	Sun, 27 Aug 2000 17:25:24 +0000
Subject:	Re: SAPI.c: strange strlcpy logic
References:	1	Groups:	php.dev
Request:	Send a blank email to php-dev+get-30818@lists.php.net to get a copy of this message

Well it seems wrong to me :) Andi At 11:43 27/08/00 +0200, Sascha Schumann wrote:

    Around line 415:
                    newlen += sizeof("Content-type: ");
                    newheader = emalloc(newlen);
                    strlcpy(newheader, "Content-type: ", newlen);
                    strlcpy(newheader, mimetype, newlen);
    Has this ever worked? The second strlcpy should probably be a strlcat.
    - Sascha
-- PHP Development Mailing List <http://www.php.net/> To unsubscribe, e-mail: php-dev-unsubscribe@lists.php.net For additional commands, e-mail: php-dev-help@lists.php.net To contact the list administrators, e-mail: php-list-admin@lists.php.net

--- Andi Gutmans <andi@zend.com> http://www.zend.com/