Re: Patch for ldap.c with binary values support

On Tue, Aug 29, 2000 at 04:36:59PM +1100, terrence_miao@email.com wrote: > > Find the patch file for ldap.c (PHP 4.0.1pl2) with LDAP > binary values support: > > ftp://igloo.its.unimelb.edu.au/pub/Linux/PHP4/ I'm not sure what to think of this. Good points: Ease of use, one can easily handle both text and binary data at the same time, to use ldap_get_values_len for all binary data might be awkward. Bad points: There is some extra overhead and in most cases people will have only text and want maximum performance. From user perspective: If I'm not using binary data, your patch is no good for me. If I'm using binary data infrequently, I can manage with ldap_get_values_len, but your patch would make things a little bit easier. If I'm using a lot of binary data often, your patch will simplify things greatly. So my conclusion is that your patch doesn't make new things possible, but makes use of binary data easier while giving less performance. If the performance hit is close to 0 (might be) then that may not be an issue. Well, that was just my immediate thoughts. Stig