PHP 4.0 Bug #6559: yp_first() and yp_next() results handled wrong in ext/yp/yp.c
| From: | gert at gerts dot net | Date: | Tue, 05 Sep 2000 18:31:58 +0000 |
| Subject: | PHP 4.0 Bug #6559: yp_first() and yp_next() results handled wrong in ext/yp/yp.c | ||
| Groups: | php.dev | ||
| Request: | Send a blank email to php-dev+get-32217@lists.php.net to get a copy of this message | ||
From: gert@gerts.net
Operating system: Solaris 8 (x86)
PHP version: 4.0.2
PHP Bug Type: NIS related
Bug description: yp_first() and yp_next() results handled wrong in ext/yp/yp.c
The key/value pairs that libnsl's yp_first/yp_next return contain
a trailing NEWLINE as per NIS specs. These NEWLINEs are
not chopped off before returning the key/value pair to the users's PHP
code. Hence you end up with newlines in PHP hashes.
Below is the context diff for the fix.
regards,
Gert
*** yp.c.orig Mon Jun 5 21:47:45 2000
--- yp.c Tue Sep 5 19:37:54 2000
***************
*** 151,156 ****
--- 151,158 ----
RETURN_FALSE;
}
array_init(return_value);
+ outkey[outkeylen] = 0;
+ outval[outvallen] = 0;
add_assoc_string(return_value,"key",outkey,1);
add_assoc_string(return_value,"value",outval,1);
}
***************
*** 175,180 ****
--- 177,184 ----
RETURN_FALSE;
}
+ outkey[outkeylen] = 0;
+ outval[outvallen] = 0;
array_init(return_value);
add_assoc_string(return_value,outkey,outval,1);
}