Bug #6916: blob->savefromfile doesn't work for binary files
| From: | mb at sime dot com | Date: | Thu, 28 Sep 2000 06:11:05 +0000 |
| Subject: | Bug #6916: blob->savefromfile doesn't work for binary files | ||
| Groups: | php.dev | ||
| Request: | Send a blank email to php-dev+get-33778@lists.php.net to get a copy of this message | ||
From: mb@sime.com
Operating system: Windows, OCI8
PHP version: 3.0.16
PHP Bug Type: Oracle related
Bug description: blob->savefromfile doesn't work for binary files
In line 2708 the input file for the blob isn't opened in binary mode, so upload of binary data
like images doesn't work on MS Windows platforms. Possibly should check if clob or blob and set
O_BINARY accordingly.
Modified line:
if ((fp = open(filename, O_RDONLY | O_BINARY)) == -1) {
works OK.