Re: 4.0.3RC1 reports on *BSD, Alpha and ia64: ok overall

From: Date: Tue, 03 Oct 2000 11:20:26 +0000
Subject: Re: 4.0.3RC1 reports on *BSD, Alpha and ia64: ok overall
References: 1 2 3  Groups: php.dev php.qa 
Request: Send a blank email to php-dev+get-34147@lists.php.net to get a copy of this message
Andi Gutmans wrote:
I think SCRIPT_FILENAME should be SCRIPT_NAME. Andi At 12:37 PM 10/3/00 +0300, Andi Gutmans wrote:
Can you try and edit cgi_main.c line 315 and change: SG(request_info).request_uri = getenv("PATH_INFO"); to: SG(request_info).request_uri = getenv("PATH_INFO"); if (!SG(request_info).request_uri || !SG(request_info).request_uri[0]) { SG(request_info).request_uri = getenv("SCRIPT_FILENAME"); } I don't know if this is supposed to fix it but it might.
Fixed, on my RH6.2 setup with --enable-discard-path and on my NetBSD setup too, also with --enable-discard-path. It's indeed SCRIPT_NAME, it gives me: <img src="/cgi-bin/info.cgi?=PHPE9568F34-D428-11d2-A769-00AA001ACF42" SCRIPT_FILENAME would give me: <img src="/opt/apache/cgi-bin/info.cgi?=PHPE9568F34-D428-11d2-A769-00AA001ACF42" And Netscape 4.x on Unix display images. ok, my PHP setup here is nearly perfect ! I just need cURL to compile with PHP and, then... I'll start thinking of Sablotron. This needs to be tested on Win32 and in normal cgi mode in Unix. I really don't know if it should be in 4.0.3, images not displaying is no so important and it's the only way this bug showed up, I don't know if the fix affects cgi's behaviour in another way. Shouldn't the fix be part of the #if DISCARD_PATH as the bug only showed when using --enable-discard-path ?
Here're reports with 4.0.3RC1 (from php.net/~andi) on various platforms: there seems to be non showstopper bugs for me with the default setup. The only problem would be build broken on Digital Unix when enabling sockets. [snip] A little problem though: there're still wrong path with --enable-discard-mode and phpinfo() images, see: http://www.epita.fr:8000/~cahagn_o/php/info.php see bugs: #4081 #6115
Do you have any idea what's wrong?
The image path iw wrong: <img src="?=PHPE9568F34-D428-11d2-A769-00AA001ACF42" it should be: <img src="/path/to/file.php?=PHPE9568F34-D428-11d2-A769-00AA001ACF42" There were talks about that but it never got fixed as it was not seen as a critical bug: http://bugs.php.net/?id=4081 (last update talks about the CGI SAPI).
I don't know the exact behavior of all of these URI and SCRIPT_NAME things and someone needs to help out here to get it fixed. I remember that after I fixed a problem with discard_path over a couple of months ago ppl were happy and said it started working again after months of not working.
-- Olivier.Cahagne@epita.fr

« previous php.dev (#34147) next »