Please review patch

This fix looks valid to me, and it solves a problem I've been having. I'd like to commit it so that it makes it into 4.0.3. Can a build-meister check it over to make sure that it's not breaking anything? ----- Forwarded message from tilmann@cs.dartmouth.edu ----- Date: 10 Oct 2000 05:42:31 -0000 From: tilmann@cs.dartmouth.edu Reply-To: tilmann@cs.dartmouth.edu Subject: [PHP-DEV] PHP 4.0 Bug #7109: make install fails in pear subdirectory To: php-dev@lists.php.net From: tilmann@cs.dartmouth.edu Operating system: Mac OS X Server 1.2 PHP version: 4.0.2 PHP Bug Type: *Install and Config Bug description: make install fails in pear subdirectory Setup: installing PHP 4.0.2 as a DSO for Apache 1.3.12 under Mac OS X Server 1.2 via the quick install. Apache 1.3.12 is under /usr/local/src/apache_1.3.12/; PHP 4.0.2 under /usr/local/src/php-4.0.2/ . Configure: ./configure --mysql=/usr/local --with-apxs=/usr/local/sbin/apxs Problem: "make install" (the last step in the quick install) fails in the pear subdirectory -- $$i gets the entire path, which causes $(peardir)/$$dir to be the wrong path. Solution: when "make install" breaks with the error, cd into the pear subdirectory, 'vi -c ":57" Makefile' and change the line as shown below: 55: for i in PEAR.php; do \ 56: dir=echo $$i|sed 's%[^/][^/]*$$%%'; \ 57: $(INSTALL_DATA) $$i $(peardir); \ 58: done; \ (ie, take out "$(builddir)/" and "/$$dir") Save and quit, and run "make install" from within the pear directory. -- Edit Bug report at: http://bugs.php.net/?id=7109&edit=1 -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, e-mail: php-dev-unsubscribe@lists.php.net For additional commands, e-mail: php-dev-help@lists.php.net To contact the list administrators, e-mail: php-list-admin@lists.php.net ----- End forwarded message ----- -chuck -- Charles Hagenbuch, <chuck@horde.org> must... find... acorns... *thud*